lkml.org 
[lkml]   [2019]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2,net-next, 2/3] Drivers: hv: vmbus: Add dev_num to sysfs
Date


> -----Original Message-----
> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Monday, December 30, 2019 8:35 PM
> To: Haiyang Zhang <haiyangz@microsoft.com>; sashal@kernel.org; linux-
> hyperv@vger.kernel.org; netdev@vger.kernel.org
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; KY Srinivasan
> <kys@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> olaf@aepfle.de; vkuznets <vkuznets@redhat.com>; davem@davemloft.net;
> linux-kernel@vger.kernel.org
> Subject: RE: [PATCH V2,net-next, 2/3] Drivers: hv: vmbus: Add dev_num to sysfs
>
> From: Haiyang Zhang <haiyangz@microsoft.com> Sent: Monday, December 30,
> 2019 12:14 PM
> >
> > It's a number based on the vmbus device offer sequence.
>
> Let's use "VMBus" as the capitalization.
I will.

>
> > Useful for device naming when using Async probing.
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > ---
> > Documentation/ABI/stable/sysfs-bus-vmbus | 8 ++++++++
> > drivers/hv/vmbus_drv.c | 13 +++++++++++++
> > 2 files changed, 21 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-bus-vmbus
> > b/Documentation/ABI/stable/sysfs-bus-vmbus
> > index 8e8d167..a42225d 100644
> > --- a/Documentation/ABI/stable/sysfs-bus-vmbus
> > +++ b/Documentation/ABI/stable/sysfs-bus-vmbus
> > @@ -49,6 +49,14 @@ Contact: Stephen Hemminger
> <sthemmin@microsoft.com>
> > Description: This NUMA node to which the VMBUS device is
> > attached, or -1 if the node is unknown.
> >
> > +What: /sys/bus/vmbus/devices/<UUID>/dev_num
> > +Date: Dec 2019
> > +KernelVersion: 5.5
> > +Contact: Haiyang Zhang <haiyangz@microsoft.com>
> > +Description: A number based on the vmbus device offer sequence.
>
> The capitalization of "VMBus" is already inconsistent in this file in that
> we have "VMBus" and "VMBUS" in the text. Let's not introduce another
> capitalization -- use "VMBus".

I will use "VMBus".
Thanks,
- Haiyang

\
 
 \ /
  Last update: 2019-12-31 16:53    [W:0.039 / U:4.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site