lkml.org 
[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] powerpc/mpc85xx: also write addr_h to spin table for 64bit boot entry
Hi Scott,

Thanks for your time to review this patch

Based on your suggestion, I have verified below new patches that pass
compilation with and without CONFIG_RELOCATABLE

https://lore.kernel.org/patchwork/patch/1173548
https://lore.kernel.org/patchwork/patch/1173547

On Wed, Dec 25, 2019 at 3:19 PM Yingjie Bai <byj.tea@gmail.com> wrote:
>
> Thanks Scott, I will test to see if returning phys_addr_t in __pa()
> works for my setup.
>
> And another thin I will test is to compile without CONFIG_RELOCATABLE
> before resubmitting the patch.
>
> On Wed, Dec 25, 2019 at 2:53 PM Scott Wood <oss@buserror.net> wrote:
> >
> > On Wed, 2019-12-25 at 11:24 +0800, Yingjie Bai wrote:
> > > Hi Scott,
> > >
> > > __pa() returns 64bit in my setup.
> > >
> > > in arch/powerpc/include/asm/page.h
> > >
> > > #if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
> > > #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) +
> > > VIRT_PHYS_OFFSET))
> > > #define __pa(x) ((unsigned long)(x) - VIRT_PHYS_OFFSET)
> > > #else
> > > #ifdef CONFIG_PPC64
> > > ...
> > >
> > >
> > >
> > > /* See Description below for VIRT_PHYS_OFFSET */
> > > #if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
> > > #ifdef CONFIG_RELOCATABLE
> > > #define VIRT_PHYS_OFFSET virt_phys_offset
> > > #else
> > > #define VIRT_PHYS_OFFSET (KERNELBASE - PHYSICAL_START)
> > > #endif
> > > #endif
> >
> > OK, so it's the lack of CONFIG_RELOCATABLE causing the build to fail. Ideally
> > we'd make __pa() consistently return phys_addr_t, even if the upper bits are
> > known to always be zero in a particular config.
> >
> > -Scott
> >
> >

\
 
 \ /
  Last update: 2019-12-30 08:43    [W:0.040 / U:1.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site