lkml.org 
[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 13/16] usb: phy: tegra: Keep CPU interrupts enabled
On Sat, Dec 28, 2019 at 11:33:55PM +0300, Dmitry Osipenko wrote:
> There is no good reason for disabling of CPU interrupts in order to
> protect the utmip_pad_count modification.

Since there are sleeping functions called outside of the locked sections,
this should be a mutex instead. OTOH if the spin_lock is to protect register
write against IRQ handler, then the patch is wrong.

[...]
> - spin_unlock_irqrestore(&utmip_pad_lock, flags);
> + spin_unlock(&utmip_pad_lock);
>
> clk_disable_unprepare(phy->pad_clk);

Best Regards,
Michał Mirosław

\
 
 \ /
  Last update: 2019-12-30 21:37    [W:0.124 / U:8.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site