lkml.org 
[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP
On Mon, Dec 30, 2019 at 4:32 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> If CONFIG_SWAP=n, it does not make much sense to offer the user the
> option to enable support for swapping over NFS, as that will still fail
> at run time:
>
> # swapon /swap
> swapon: /swap: swapon failed: Function not implemented
>
> Fix this by adding a dependency on CONFIG_SWAP.
>
> Fixes: a564b8f0398636ba ("nfs: enable swap on NFS")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Marked RFC, as this still doesn't seem to work.
> When enabled, the kernel log is spammed with:
>
> [ 449.371536] __swap_writepage: 413288 callbacks suppressed
> [ 449.371577] Write error on dio swapfile (10047488)
> [ 449.382435] Write error on dio swapfile (14147584)
> [ 449.387320] Write error on dio swapfile (10919936)
> [ 449.392474] Write error on dio swapfile (8945664)
> [ 449.397263] Write error on dio swapfile (24256512)
> [ 449.402330] Write error on dio swapfile (14307328)
> [ 449.407195] Write error on dio swapfile (229376)
> [ 449.412031] Write error on dio swapfile (10293248)
> [ 449.416891] Write error on dio swapfile (2007040)

FWIW, swap over /dev/loop0 using a file on nfsroot also doesn't work: system
hangs, but is still reponsive to ping.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2019-12-30 16:55    [W:0.027 / U:4.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site