lkml.org 
[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node
On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> "samsung,s3c6400-hsotg" should be enough.

The more detailed compatible is almost always "enough". Some other nodes
also have detailed+generic compatible. In this case there is a driver
matching "snps,dwc2" so why removing it?

Best regards,
Krzysztof

>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index b016b0b68306..d4866269f4ee 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -362,7 +362,7 @@
> };
>
> hsotg: hsotg@12480000 {
> - compatible = "samsung,s3c6400-hsotg", "snps,dwc2";
> + compatible = "samsung,s3c6400-hsotg";
> reg = <0x12480000 0x20000>;
> interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cmu CLK_USBOTG>;
> --
> 2.15.0
>

\
 
 \ /
  Last update: 2019-12-30 16:39    [W:0.063 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site