[lkml]   [2019]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH] mips: vdso: conditionalize 32-bit time functions on COMPAT_32BIT_TIME
On Tue, Dec 24, 2019 at 2:54 PM Jason A. Donenfeld <> wrote:
> When the VDSO falls back to 32-bit time functions on kernels with
> COMPAT_32BIT_TIME=n, userspace becomes corrupted and appears to crash
> shortly after, with something like:
> [ 0.359617] do_page_fault(): sending SIGSEGV to init for invalid read access from 000000007ff790d0
> [ 0.359843] epc = 0000000077e45df4 in[77da6000+de000]
> [ 0.360319] ra = 0000000010000c50 in init[10000000+2000]
> [ 0.364456] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> This can be reproduced with simply calling `clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &ts)`,
> since `CLOCK_PROCESS_CPUTIME_ID` is not exported to the VDSO, invoking
> the syscall callback branch. This crash was observed with musl 1.20's
> clock_gettime implementation:

Thanks for the bug report! I'm not completely sure why this fails in
this particular
way though. I assume you are using musl-1.1.20, not a musl-1.2.0 snapshot
(the version 1.20 you list does not exist), so the combination you are testing
is supposed to just return -ENOSYS here to match the behavior of hte
system call.

> --- a/arch/mips/include/asm/vdso/gettimeofday.h
> +++ b/arch/mips/include/asm/vdso/gettimeofday.h
> @@ -107,7 +107,7 @@ static __always_inline int clock_getres_fallback(
> return error ? -ret : ret;
> }
> -#if _MIPS_SIM != _MIPS_SIM_ABI64
> +#if _MIPS_SIM != _MIPS_SIM_ABI64 && defined(CONFIG_COMPAT_32BIT_TIME)

I don't think this is the correct fix, it may actually make it worse
by changing the vdso implementation for clock_gettime32()
to fall back to clock_gettime64(), which would appear to work
correctly before y2038 but fail afterwards. How about this one:

diff --git a/arch/mips/vdso/ b/arch/mips/vdso/
index da4627430aba..0bdc6a026be8 100644
--- a/arch/mips/vdso/
+++ b/arch/mips/vdso/
@@ -93,9 +93,11 @@ VERSION
LINUX_2.6 {
+#if (_MIPS_SIM == _MIPS_SIM_ABI64) || defined(CONFIG_COMPAT_32BIT_TIME)
That should ensure that no user space can call the old vdso
functions on a kernel that intentionally breaks the actual


 \ /
  Last update: 2019-12-30 12:58    [W:0.063 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site