lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 025/135] ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit 45c1380358b12bf2d1db20a5874e9544f56b34ab ]

    In the implementation of sof_set_get_large_ctrl_data() there is a memory
    leak in case an error. Release partdata if sof_get_ctrl_copy_params()
    fails.

    Fixes: 54d198d5019d ("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Link: https://lore.kernel.org/r/20191027215330.12729-1-navid.emamdoost@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/sof/ipc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c
    index 20dfca9c93b76..c4086186722f3 100644
    --- a/sound/soc/sof/ipc.c
    +++ b/sound/soc/sof/ipc.c
    @@ -578,8 +578,10 @@ static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev,
    else
    err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata,
    sparams);
    - if (err < 0)
    + if (err < 0) {
    + kfree(partdata);
    return err;
    + }

    msg_bytes = sparams->msg_bytes;
    pl_size = sparams->pl_size;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-03 23:40    [W:4.643 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site