lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC v7 net-next 3/1] netronome: use the new txqueue timeout argument
On Tue, 3 Dec 2019 02:32:14 -0500, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> untested
>
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 41a808b14d76..26f1fb19d0aa 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -1323,13 +1323,8 @@ nfp_net_tx_ring_reset(struct nfp_net_dp *dp, struct nfp_net_tx_ring *tx_ring)
> static void nfp_net_tx_timeout(struct net_device *netdev, unsigned int txqueue)
> {
> struct nfp_net *nn = netdev_priv(netdev);
> - int i;
>
> - for (i = 0; i < nn->dp.netdev->real_num_tx_queues; i++) {
> - if (!netif_tx_queue_stopped(netdev_get_tx_queue(netdev, i)))
> - continue;
> - nn_warn(nn, "TX timeout on ring: %d\n", i);
> - }
> + nn_warn(nn, "TX timeout on ring: %d\n", txqueue);

%u

> nn_warn(nn, "TX watchdog timeout\n");

I think we can drop this warning now.

With that:

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thanks!

\
 
 \ /
  Last update: 2019-12-03 19:10    [W:0.026 / U:17.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site