lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 02/13] exfat: add super block operations
On Friday 20 December 2019 01:24:08 Namjae Jeon wrote:
> This adds the implementation of superblock operations for exfat.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
> fs/exfat/super.c | 732 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 732 insertions(+)
> create mode 100644 fs/exfat/super.c
>
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c
> new file mode 100644
> index 000000000000..07687997c7f8
> --- /dev/null
> +++ b/fs/exfat/super.c

...

> +enum {
> + Opt_uid,
> + Opt_gid,
> + Opt_umask,
> + Opt_dmask,
> + Opt_fmask,
> + Opt_allow_utime,
> + Opt_charset,
> + Opt_utf8,
> + Opt_case_sensitive,
> + Opt_tz,
> + Opt_errors,
> + Opt_discard,
> +};
> +
> +static const struct fs_parameter_spec exfat_param_specs[] = {
> + fsparam_u32("uid", Opt_uid),
> + fsparam_u32("gid", Opt_gid),
> + fsparam_u32oct("umask", Opt_umask),
> + fsparam_u32oct("dmask", Opt_dmask),
> + fsparam_u32oct("fmask", Opt_fmask),
> + fsparam_u32oct("allow_utime", Opt_allow_utime),
> + fsparam_string("iocharset", Opt_charset),
> + fsparam_flag("utf8", Opt_utf8),

Hello! What is the purpose of having extra special "utf8" mount option?
Is not one "iocharset=utf8" option enough?

> + fsparam_flag("case_sensitive", Opt_case_sensitive),
> + fsparam_string("tz", Opt_tz),
> + fsparam_enum("errors", Opt_errors),
> + fsparam_flag("discard", Opt_discard),
> + {}
> +};

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-29 14:41    [W:0.179 / U:4.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site