lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
From
Date
>> Please add the tag “Fixes” to your change description.
>
> I got the results from "git blame":
> git blame -L 570,575 drivers/gpu/drm/v3d/v3d_gem.c

> 0d352a3a8a1f2 (Iago Toral Quiroga 2019-09-16 09:11:25 +0200 571)                kfree(bin);
> a783a09ee76d6 (Eric Anholt        2019-04-16 15:58:53 -0700 572)                v3d_job_put(&render->base);
> 29cd13cfd7624 (Navid Emamdoost    2019-10-21 13:52:49 -0500 573)                kfree(bin);
> a783a09ee76d6 (Eric Anholt        2019-04-16 15:58:53 -0700 574)                return ret;

>

> commit 29cd13cfd7624726d9e6becbae9aa419ef35af7f
> Author: Navid Emamdoost <navid.emamdoost@gmail.com>
> Date:   Mon Oct 21 13:52:49 2019 -0500
>
>     drm/v3d: Fix memory leak in v3d_submit_cl_ioctl
>
>     In the impelementation of v3d_submit_cl_ioctl() there are two memory


It seems that this patch got insufficient code review attention before.
https://lore.kernel.org/dri-devel/20191021185250.26130-1-navid.emamdoost@gmail.com/
https://lore.kernel.org/patchwork/comment/1342088/
https://lore.kernel.org/patchwork/patch/1142603/


Thus the fix chain will be extended.

Regards,
Markus

\
 
 \ /
  Last update: 2019-12-29 13:15    [W:0.043 / U:4.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site