lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 236/434] spi: dw: Fix Designware SPI loopback
    Date
    From: Thor Thayer <thor.thayer@linux.intel.com>

    [ Upstream commit 1403cfa69d310781f9548951c97725c67ffcf613 ]

    The SPI_LOOP is set in spi->mode but not propagated to the register.
    A previous patch removed the bit during a cleanup.

    Fixes: e1bc204894ea ("spi: dw: fix potential variable assignment error")
    Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
    Link: https://lore.kernel.org/r/1572985330-5525-1-git-send-email-thor.thayer@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-dw.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
    index 9a49e073e8b7..076652d3d051 100644
    --- a/drivers/spi/spi-dw.c
    +++ b/drivers/spi/spi-dw.c
    @@ -308,7 +308,8 @@ static int dw_spi_transfer_one(struct spi_controller *master,
    cr0 = (transfer->bits_per_word - 1)
    | (chip->type << SPI_FRF_OFFSET)
    | ((((spi->mode & SPI_CPOL) ? 1 : 0) << SPI_SCOL_OFFSET) |
    - (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET))
    + (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET) |
    + (((spi->mode & SPI_LOOP) ? 1 : 0) << SPI_SRL_OFFSET))
    | (chip->tmode << SPI_TMOD_OFFSET);

    /*
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 18:52    [W:2.073 / U:0.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site