lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 005/219] net: gemini: Fix memory leak in gmac_setup_txqs
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit f37f710353677639bc5d37ee785335994adf2529 ]

    In the implementation of gmac_setup_txqs() the allocated desc_ring is
    leaked if TX queue base is not aligned. Release it via
    dma_free_coherent.

    Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/cortina/gemini.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/ethernet/cortina/gemini.c
    +++ b/drivers/net/ethernet/cortina/gemini.c
    @@ -577,6 +577,8 @@ static int gmac_setup_txqs(struct net_de

    if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {
    dev_warn(geth->dev, "TX queue base is not aligned\n");
    + dma_free_coherent(geth->dev, len * sizeof(*desc_ring),
    + desc_ring, port->txq_dma_base);
    kfree(skb_tab);
    return -ENOMEM;
    }

    \
     
     \ /
      Last update: 2019-12-29 18:29    [W:2.258 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site