[lkml]   [2019]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
> v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.

I would prefer a wording like “kfree() was called for the same variable twice
within an if branch.”.

> Fix it by removing the latter one.

I find the wording “Delete a duplicate function call.” more appropriate.

Please add the tag “Fixes” to your change description.


 \ /
  Last update: 2019-12-28 21:47    [W:0.039 / U:36.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site