[lkml]   [2019]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference
> in_dev_get may return a NULL object.

I would prefer a wording like “A null pointer can be returned by in_dev_get().”.

> The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.

How do you think about the wording suggestion “Thus add a corresponding check
so that a null pointer dereference will be avoided at this place.”?

Please add also the tag “Fixes” to your change description.


 \ /
  Last update: 2019-12-28 20:51    [W:0.029 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site