lkml.org 
[lkml]   [2019]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT] Networking
On Sat, Dec 21, 2019 at 6:09 PM David Miller <davem@davemloft.net> wrote:
>
> Antoine Tenart (2):
> of: mdio: export of_mdiobus_child_is_phy

I didn't notice until now (bad me - I've actually been taking a few
days off due to xmas), but this causes a new warning in some
configurations.

In particular, it causes a warning about

'of_mdiobus_child_is_phy' defined but noy used

because when CONFIG_OF_MDIO is disabled, the <linux/of_mdio.h> header now has

static bool of_mdiobus_child_is_phy(struct device_node *child)
{
return false;
}

which is all kinds of stupid.

I'm assuming that dummy function should just be marked "inline", the
way the other helper dummy functions are defined when OF_MDIO is not
enabled.

Linus

\
 
 \ /
  Last update: 2019-12-27 23:14    [W:0.028 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site