[lkml]   [2019]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: linux-next: Fixes tags need some work in the block tree
On 12/27/19 1:39 PM, Stephen Rothwell wrote:
> Hi Jens,
> On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <> wrote:
>> On 12/27/19 1:27 PM, Florian Fainelli wrote:
>>> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
>>>> In commit
>>>> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>>> Fixes tags
>>>> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>>>> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>>> have this problem:
>>>> - Target SHA1s do not exist
>>>> Perhaps you meant
>>>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>>>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
>>> Yes, those are the two that should have been used, the two commits were
>>> extracted from a downstream tree where the upstream commits ended up
>>> looking slightly different, my script does not (yet) rewrite those, Jens
>>> would you want me to resubmit or can you rewrite the commit message in
>>> place?
>> It's too late unfortunately, Linus already pulled it. So we'll have to
>> live with it, at least the commit titles are correct so it should be
>> manageable.
> Unfortunately, even the titles are not correct, so they took me a
> little time to find the correct commits :-( This means it will also
> take the stable maintainers a bit of time.

Yeah I see, the 2nd one is not. Gah, that really sucks. I'll let stable

Florian, please ensure that future submissions have both the right titles
and shas.

Jens Axboe

 \ /
  Last update: 2019-12-27 21:45    [W:0.032 / U:3.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site