lkml.org 
[lkml]   [2019]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'cs_block'
From
Date
On 2019/12/26 11:44, Chao Yu wrote:
> On 2019/12/24 20:43, YueHaibing wrote:
>> fs/f2fs/segment.c: In function fix_curseg_write_pointer:
>> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable]
>>
>> It is never used since commit 362d8a920384 ("f2fs: Check
>> write pointer consistency of open zones") , so remove it.
>
> Thanks for the fix!
>
> Do you mind merging this patch to original patch? as it's still
> pending in dev branch.

It's ok for me.

>
> Thanks,
>
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> fs/f2fs/segment.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index a951953..72cf257 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -4482,14 +4482,13 @@ static int fix_curseg_write_pointer(struct f2fs_sb_info *sbi, int type)
>> struct f2fs_dev_info *zbd;
>> struct blk_zone zone;
>> unsigned int cs_section, wp_segno, wp_blkoff, wp_sector_off;
>> - block_t cs_zone_block, wp_block, cs_block;
>> + block_t cs_zone_block, wp_block;
>> unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT;
>> sector_t zone_sector;
>> int err;
>>
>> cs_section = GET_SEC_FROM_SEG(sbi, cs->segno);
>> cs_zone_block = START_BLOCK(sbi, GET_SEG_FROM_SEC(sbi, cs_section));
>> - cs_block = START_BLOCK(sbi, cs->segno) + cs->next_blkoff;
>>
>> zbd = get_target_zoned_dev(sbi, cs_zone_block);
>> if (!zbd)
>>
>
> .
>

\
 
 \ /
  Last update: 2019-12-26 07:06    [W:0.045 / U:18.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site