Messages in this thread |  | | Subject | Re: [PATCH v1 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings | From | Taniya Das <> | Date | Fri, 27 Dec 2019 10:05:15 +0530 |
| |
Hello Rob,
Thanks for the review comments.
On 12/16/2019 11:31 PM, Rob Herring wrote: > On Wed, Dec 04, 2019 at 08:21:56AM +0000, Taniya Das wrote: >> The MSS clock provider have a bunch of generic properties that >> are needed in a device tree. Add a YAML schemas for those. >> >> Signed-off-by: Taniya Das <tdas@codeaurora.org> >> --- >> .../devicetree/bindings/clock/qcom,mss.yaml | 40 ++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml b/Documentation/devicetree/bindings/clock/qcom,mss.yaml >> new file mode 100644 >> index 0000000..4494a6b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml >> @@ -0,0 +1,40 @@ >> +# SPDX-License-Identifier: GPL-2.0-only > > Dual license new bindings please: > > (GPL-2.0-only OR BSD-2-Clause) >
Will update the license.
>> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Modem Clock Controller Binding >> + >> +maintainers: >> + - Taniya Das <tdas@codeaurora.org> >> + >> +description: | >> + Qualcomm modem clock control module which supports the clocks. >> + >> +properties: >> + compatible : >> + enum: >> + - qcom,mss-sc7180 > > Normal order is 'qcom,sc7180-mss'. > My bad. >> + >> + '#clock-cells': >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - '#clock-cells' > > Add: > > additionalItems: false >
Will add it in the next patch.
>> + >> +examples: >> + # Example of MSS with clock nodes properties for SC7180: >> + - | >> + clock-controller@41aa000 { >> + compatible = "qcom,sc7180-mss"; >> + reg = <0x041aa000 0x100>; >> + reg-names = "cc"; > > Not documented, nor necessary. >
Will remove this.
>> + #clock-cells = <1>; >> + }; >> +... >> -- >> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member >> of the Code Aurora Forum, hosted by the Linux Foundation. >>
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation.
--
|  |