Messages in this thread |  | | From | Po Liu <> | Subject | RE: [EXT] Re: [net-next] enetc: add support time specific departure base on the qos etf | Date | Fri, 27 Dec 2019 02:11:41 +0000 |
| |
Br, Po Liu
> -----Original Message----- > From: David Miller <davem@davemloft.net> > Sent: 2019年12月27日 7:10 > To: Po Liu <po.liu@nxp.com> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; > vinicius.gomes@intel.com; Claudiu Manoil <claudiu.manoil@nxp.com>; > Vladimir Oltean <vladimir.oltean@nxp.com>; Alexandru Marginean > <alexandru.marginean@nxp.com>; Xiaoliang Yang > <xiaoliang.yang_1@nxp.com>; Roy Zang <roy.zang@nxp.com>; Mingkai Hu > <mingkai.hu@nxp.com>; Jerry Huang <jerry.huang@nxp.com>; Leo Li > <leoyang.li@nxp.com>; ivan.khoronzhuk@linaro.org > Subject: [EXT] Re: [net-next] enetc: add support time specific departure base on > the qos etf > > Caution: EXT Email > > From: Po Liu <po.liu@nxp.com> > Date: Mon, 23 Dec 2019 03:42:39 +0000 > > > - Transmit checksum offloads and time specific departure operation are > > mutually exclusive. > > I do not see anything which enforces this conflict. > > It looks to me like if the user configures time specific departure, and TX SKBs will > be checksum offloaded, the time specific departure will simply not be performed. > > If true, this behavior will be very surprising for the user. > > Instead, the configuration operation that creates the conflict should throw and > error and fail.
I would fix it.
> > Thank you.
|  |