Messages in this thread |  | | Date | Thu, 26 Dec 2019 22:22:02 +0100 | From | Christophe Leroy <> | Subject | Re: [PATCH -next] powerpc/pmac/smp: Fix old-style declaration |
| |
YueHaibing <yuehaibing@huawei.com> a écrit :
> There expect the 'static' keyword to come first in a declaration > > arch/powerpc/platforms/powermac/smp.c:664:1: warning: static is not > at beginning of declaration [-Wold-style-declaration] > arch/powerpc/platforms/powermac/smp.c:665:1: warning: static is not > at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/platforms/powermac/smp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powermac/smp.c > b/arch/powerpc/platforms/powermac/smp.c > index f95fbde..7233b85 100644 > --- a/arch/powerpc/platforms/powermac/smp.c > +++ b/arch/powerpc/platforms/powermac/smp.c > @@ -661,8 +661,8 @@ static void smp_core99_gpio_tb_freeze(int freeze) > #endif /* !CONFIG_PPC64 */ > > /* L2 and L3 cache settings to pass from CPU0 to CPU1 on G4 cpus */ > -volatile static long int core99_l2_cache; > -volatile static long int core99_l3_cache; > +static volatile long int core99_l2_cache; > +static volatile long int core99_l3_cache;
Is it correct to declare it as volatile ?
See https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html
Christophe
|  |