[lkml]   [2019]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip: sched/core] sched/fair: Make task_fits_capacity() consider uclamp restrictions
The following commit has been merged into the sched/core branch of tip:

Commit-ID: a7008c07a568278ed2763436404752a98004c7ff
Author: Valentin Schneider <>
AuthorDate: Wed, 11 Dec 2019 11:38:50
Committer: Ingo Molnar <>
CommitterDate: Wed, 25 Dec 2019 10:42:09 +01:00

sched/fair: Make task_fits_capacity() consider uclamp restrictions

task_fits_capacity() drives CPU selection at wakeup time, and is also used
to detect misfit tasks. Right now it does so by comparing task_util_est()
with a CPU's capacity, but doesn't take into account uclamp restrictions.

There's a few interesting uses that can come out of doing this. For
instance, a low uclamp.max value could prevent certain tasks from being
flagged as misfit tasks, so they could merrily remain on low-capacity CPUs.
Similarly, a high uclamp.min value would steer tasks towards high capacity
CPUs at wakeup (and, should that fail, later steered via misfit balancing),
so such "boosted" tasks would favor CPUs of higher capacity.

Introduce uclamp_task_util() and make task_fits_capacity() use it.

Tested-By: Dietmar Eggemann <>
Signed-off-by: Valentin Schneider <>
Signed-off-by: Peter Zijlstra (Intel) <>
Reviewed-by: Quentin Perret <>
Reviewed-by: Vincent Guittot <>
Reviewed-by: Dietmar Eggemann <>
Cc: Linus Torvalds <>
Cc: Peter Zijlstra <>
Cc: Thomas Gleixner <>
Signed-off-by: Ingo Molnar <>
kernel/sched/fair.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1f34fa9..26c59bc 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3711,6 +3711,20 @@ static inline unsigned long task_util_est(struct task_struct *p)
return max(task_util(p), _task_util_est(p));

+static inline unsigned long uclamp_task_util(struct task_struct *p)
+ return clamp(task_util_est(p),
+ uclamp_eff_value(p, UCLAMP_MIN),
+ uclamp_eff_value(p, UCLAMP_MAX));
+static inline unsigned long uclamp_task_util(struct task_struct *p)
+ return task_util_est(p);
static inline void util_est_enqueue(struct cfs_rq *cfs_rq,
struct task_struct *p)
@@ -3822,7 +3836,7 @@ done:

static inline int task_fits_capacity(struct task_struct *p, long capacity)
- return fits_capacity(task_util_est(p), capacity);
+ return fits_capacity(uclamp_task_util(p), capacity);

static inline void update_misfit_status(struct task_struct *p, struct rq *rq)
 \ /
  Last update: 2019-12-25 11:41    [W:0.402 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site