lkml.org 
[lkml]   [2019]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface
From
Date
Hi Alim,

Would you think below explanation is OK to you?

BTW, FYI, this series was combined to the new series "scsi: ufs: add
MediaTek vendor implementations" with this same patch in it.

Thanks,
Stanley


On Fri, 2019-12-20 at 09:15 +0800, Stanley Chu wrote:
> Hi Alim,
>
> On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > > +/* UFS related SMC call */
> > > +#define MTK_SIP_UFS_CONTROL \
> > > + MTK_SIP_SMC_CMD(0x276)
> > > +
> > How about moving UFS specific stuff to MTK UFS driver and include this
> > header in driver file?
> > Rest looks fine.
>
> Thanks so much for your review.
>
> Our intention is to collect all SMC call command types in MediaTek
> Chipsets here for easier management.
>
> This is the first time we show this header thus only UFS related stuff
> is present here.
>
> > > +#endif
> > > --
> > > 2.18.0
> >
> >
>
> Thanks,
> Stanley
>


\
 
 \ /
  Last update: 2019-12-25 08:35    [W:0.038 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site