[lkml]   [2019]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected

Liran Alon <> wrote:
>> On 25 Dec 2019, at 4:21, linmiaohe <> wrote:
>> From: Miaohe Lin <>
>> We should retry writing guest memory when
>> kvm_write_guest_virt_system() failed and page fault is injected in handle_vmread().
>> Signed-off-by: Miaohe Lin <>
>Patch fix seems correct to me:
>Reviewed-by: Liran Alon <>

Thanks for your review.

>However, I suggest to rephrase commit title & message as follows:
>KVM: nVMX: vmread should not set rflags to specify success in case of #PF
>In case writing to vmread destination operand result in a #PF, vmread should not call nested_vmx_succeed() to set rflags to specify success. Similar to as done in for VMPTRST (See handle_vmptrst()).

Thanks for your sueestion, I would rephrase commit title & message accordingly.

>In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.

I'd like to submit kvm-unit-test that verifies this condition, but I am not familiar with the kvm-unit-test code yet and
also not in my recent todo list. So such a patch may come late. It would be appreciated too if you could submit this
kvm-unit-test patch. :)
Thanks again.

 \ /
  Last update: 2019-12-26 03:32    [W:0.062 / U:3.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site