lkml.org 
[lkml]   [2019]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ARM: dts: Add omap3-echo
On Wed, Dec 25, 2019 at 6:05 AM André Hentschel <nerv@dawncrow.de> wrote:
>
> Am 24.12.19 um 19:45 schrieb Tony Lindgren:
> > * André Hentschel <nerv@dawncrow.de> [191224 16:11]:
> >> This is the first generation Amazon Echo from 2016.
> >> Audio support is not yet implemented.
> >
> > OK looks good to me, just worried about one part:
> >
> >> +&sgx_module {
> >> + status = "disabled";
> >> +};
> >
> > We should have a separate am3703.dtsi or whatever the SoC model
> > disabling sgx if not there on the SoC. That way board specific
> > dts files can just include it without having to debug this issue
> > over and over.
>
> Thanks for the quick review in that time of the year!
> The sgx issue came up in newer kernels and I had to bisect it to 3b72fc895a2e57f70276b46f386f35d752adf555
> The device just wasn't booting without a message, so yes, we should make it easier for others to figure it out.
> SoC is DM3725 and only DM3730 has sgx support. And it's hard to say if the base is am37xx or omap36xx.
> But I see the reasons you picked am3703, so I would move everything from omap36xx.dtsi to am3703.dtsi except sgx?

> And then include am3703.dtsi in omap36xx.dtsi before sgx support?

I can see value in having a 3703 base and including that in the 36xx
with SGX and DSP nodes, but why not jus make SGX disabled by default.
Those who want/need it can enable it on a per-board basis.
> Or would it be better to have sgx support in a separate dtsi?

I am not sure how much DSP stuff is in there, but the DM3730 is the
AM3703 + DSP and 3D.

adam
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2019-12-25 13:54    [W:0.058 / U:24.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site