lkml.org 
[lkml]   [2019]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/13] dt-bindings: PCI: Add host mode dt-bindings for TI's J721E SoC
From
Date
Hi Rob,

On 19/12/19 5:38 AM, Rob Herring wrote:
> On Mon, Dec 09, 2019 at 02:51:43PM +0530, Kishon Vijay Abraham I wrote:
>> Add host mode dt-bindings for TI's J721E SoC.
>>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++
>> 1 file changed, 161 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> new file mode 100644
>> index 000000000000..96184e1f419f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> @@ -0,0 +1,161 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: TI J721E PCI Host (PCIe Wrapper)
>> +
>> +maintainers:
>> + - Kishon Vijay Abraham I <kishon@ti.com>
>
> There's now a PCI bus schema. Reference it here:
>
> allOf:
> - $ref: "/schemas/pci/pci-bus.yaml#"
>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ti,j721e-pcie-host
>
> Indentation.
>
>> +
>> + reg:
>> + maxItems: 4
>> +
>> + reg-names:
>> + items:
>> + - const: intd_cfg
>> + - const: user_cfg
>> + - const: reg
>> + - const: cfg
>> +
>> + ti,syscon-pcie-ctrl:
>> + description: Phandle to the SYSCON entry required for configuring PCIe mode
>> + and link speed.
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>
> You can drop the 'allOf' here if there aren't more constraints.

Do you mean I don't have to include phandle schema here? I don't seem to
be able to include $ref without allOf.

Thanks
Kishon

\
 
 \ /
  Last update: 2019-12-24 09:04    [W:0.070 / U:4.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site