lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] PM / devfreq: exynos-bus: Add error log when get event fails
From
Date
Hi,

I think that you better to use 'devfreq-event' instead of just 'event'
as following:

PM / devfreq: exynos-bus: Add error log when fail to get devfreq-event

On 12/24/19 4:19 AM, Yangtao Li wrote:
> Adding an error log makes it easier to trace the function's error path.
> Because the error code may be rewritten on return, print error code here.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/exynos-bus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 948e9340f91c..634d63fd00ea 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -126,6 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev,
>
> ret = exynos_bus_get_event(bus, &edata);
> if (ret < 0) {
> + dev_err(dev, "failed to get event from devfreq-event devices %d\n",
> + ret);

Better to make it under 80 char as following:

diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index f5d4c369c7fb..10f4fa1a0363 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -126,7 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev,

ret = exynos_bus_get_event(bus, &edata);
if (ret < 0) {
- dev_err(dev, "failed to get event from devfreq-event devices %d\n",
+ dev_err(dev,
+ "failed to get event from devfreq-event devices %d\n",
ret);
stat->total_time = stat->busy_time = 0;
goto err;

> stat->total_time = stat->busy_time = 0;
> goto err;
> }
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2019-12-24 05:01    [W:0.056 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site