lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
> On 03.12.19 14:03, Martin Kepplinger wrote:
> > Now that there is driver support, describe the accel and gyro sensor parts
> > of the LSM9DS1 IMU.
> >
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..7a92704c53ec 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -415,6 +415,13 @@
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> >
> > + accel_gyro@6a {

We prefer to use hyphen than underscore in node name. Also nodes with
unit-address should be sorted in the address.

Shawn

> > + compatible = "st,lsm9ds1-imu";
> > + reg = <0x6a>;
> > + vdd-supply = <&reg_3v3_p>;
> > + vddio-supply = <&reg_3v3_p>;
> > + };
> > +
> > magnetometer@1e {
> > compatible = "st,lsm9ds1-magn";
> > reg = <0x1e>;
> >
>
> (adding / fixing people in CC)
>
> Are there any questions about this addition or the followup fix?
>
> thanks a lot,
>
> martin

\
 
 \ /
  Last update: 2019-12-23 08:19    [W:0.060 / U:18.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site