lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes
From
Date
23.12.2019 10:46, Richard Leitner пишет:
> Hi,
> thanks for the reply.
>
> On 20/12/2019 15:00, Dmitry Osipenko wrote:
>> 19.12.2019 16:04, Richard Leitner пишет:
>>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>>> to alias it from derived boards.
>>>
>>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>>> ---
>>>   arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> ...
>
>>
>> Hello Richard,
>>
>> Why derived boards couldn't label nodes by themselves? That's what all
>> derived boards are doing already.
>
> Of course they can, but IMHO its more useful to have the same labels for
> all derived boards.
>
>>
>> BTW, upstream should benefit from the submitted changes. This is not a
>> very useful change for upstream if you're not updating the actual DTs of
>> any of the boards in arch/arm/boot/dts/*.
>
> That's true. I thought of also patching the actual DTs but wasn't sure
> if that should be in the same series...
> Based on your answer I guess it should be.
>
> Therefore I'll send a v2 soon.
>
> Thanks again & regards;richard.l

Seeing the full picture will be very helpful, thanks.

\
 
 \ /
  Last update: 2019-12-23 16:45    [W:0.035 / U:2.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site