lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] of: mdio: mark stub of_mdiobus_child_is_phy as inline
On Mon, Dec 23, 2019 at 02:24:43PM +0100, Jason A. Donenfeld wrote:
> The of_mdiobus_child_is_phy function was recently exported, with a stub
> fallback added to simply return false as a static function. The inline
> specifier was left out, leading to build time errors:
>
> In file included from linux/include/linux/fs_enet_pd.h:21,
> from linux/arch/powerpc/sysdev/fsl_soc.c:26:
> linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function]
> 58 | static bool of_mdiobus_child_is_phy(struct device_node *child)
> | ^~~~~~~~~~
>
> This commit simply adds the missing inline keyboard.

Hi Jason

It is a good idea to search the netdev list before fixing things like
this:

https://lkml.org/lkml/2019/12/23/128

Andrew

\
 
 \ /
  Last update: 2019-12-23 16:24    [W:0.032 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site