lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] thunderbolt: fix memory leak of object sw
On Mon, Dec 23, 2019 at 12:13:17PM +0200, Mika Westerberg wrote:
> On Fri, Dec 20, 2019 at 10:05:26PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > In the case where the call tb_switch_exceeds_max_depth is true
> > the error reurn path leaks memory in sw. Fix this by setting
> > the return error code to -EADDRNOTAVAIL and returning via the
> > error exit path err_free_sw_ports to free sw. sw has been kzalloc'd
> > so the free of the NULL sw->ports is fine.
> >
> > Addresses-Coverity: ("Resource leak")
> > Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Greg, can you take this to your usb-next branch where the rest of the
> USB4 stuff is?

Will do, thanks.

greg k-h

\
 
 \ /
  Last update: 2019-12-23 12:53    [W:0.031 / U:14.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site