lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/5] phy: qcom-qmp: Use register defines
On 2019-12-23 16:43, Can Guo wrote:
> On 2019-12-20 18:17, Vinod Koul wrote:
>> We already define register offsets so use them in register layout.
>>
>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>> ---
>> drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
>> b/drivers/phy/qualcomm/phy-qcom-qmp.c
>> index 66f91726b8b2..1196c85aa023 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
>> @@ -166,8 +166,8 @@ static const unsigned int
>> sdm845_ufsphy_regs_layout[] = {
>> };
>>
>> static const unsigned int sm8150_ufsphy_regs_layout[] = {
>> - [QPHY_START_CTRL] = 0x00,
>> - [QPHY_PCS_READY_STATUS] = 0x180,
>> + [QPHY_START_CTRL] = QPHY_V4_PHY_START,
>> + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS,
>
> Missed QPHY_SW_RESET?
>
> Regards,
> Can Guo.
>

My bad, just saw you added it in another patch.

Can Guo.

>> };
>>
>> static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {

\
 
 \ /
  Last update: 2019-12-23 10:08    [W:0.037 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site