lkml.org 
[lkml]   [2019]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] dt-bindings: regulator: add document bindings for mpq7920
On Sun, Dec 22, 2019 at 12:40:27AM +0100, Saravanan Sekar wrote:
> Add device tree binding information for mpq7920 regulator driver.
> Example bindings for mpq7920 are added.
>
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---
> .../bindings/regulator/mpq7920.yaml | 135 ++++++++++++++++++
> 1 file changed, 135 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mpq7920.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mpq7920.yaml b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
> new file mode 100644
> index 000000000000..a60d3ef04c05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
> @@ -0,0 +1,135 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mpq7920.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MPQ7920 PMIC
> +
> +maintainers:
> + - Saravanan Sekar <sravanhome@gmail.com>
> +
> +properties:
> + $nodename:
> + pattern: "mpq@[0-9a-f]{1,2}"

This is still not a valid node name

> + compatible:
> + enum:
> + - mps,mpq7920
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + type: object
> + description: |
> + list of regulators provided by this controller, must be named
> + after their hardware counterparts BUCK[1-4], one LDORTC, and LDO[2-5]
> + The valid names for regulators are
> + buck1, buck2, buck3, buck4, ldortc, ldo2, ldo3, ldo4, ldo5

These should be validated.

> + properties:

If it's properties under the regulators node, it should be at one more
indentation level.

> + mps,time-slot:

This should have an allOf here

> + - $ref: "/schemas/types.yaml#/definitions/uint8"
> + - enum: [ 0, 1, 2, 3 ]
> + - default: 0
> + description: |
> + each regulator output shall be delayed during power on/off sequence which
> + based on configurable time slot value, must be one of following corresponding
> + value 0.5ms, 2ms, 8ms, 16ms

And this should be under the property, not at the same level.

Did you run dt_bindings_check?

Maxime
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-22 14:13    [W:0.038 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site