lkml.org 
[lkml]   [2019]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/3] tty/leds: implement a trigger for ttys
On Tue 2019-12-17 18:22:32, Greg Kroah-Hartman wrote:
> On Tue, Dec 17, 2019 at 05:58:13PM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > v3 of this series was sent earlier today starting with Message-Id:
> > 20191217150736.1479-1-u.kleine-koenig@pengutronix.de.
> >
> > v4 only changes patch 3 dropping a few printks, fixing the show callback
> > for the dev attribute to match its store function. And I moved
> > ledtrig_tty_restart() into the already existing if (tty) {...} block in
> > dev_store and dropped the same check from the former function.
> >
>
> All looks good to me, so if the LED developers give their ack, I can
> take it in my tty tree.

Nothing obviously wrong in 1 and 2 of the series. Feel free to take
them.

I fear conflicts if you take 3/ through your tree, so perhaps I can
take it through the LEDs?

But I'll have some comments there.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-21 19:37    [W:0.054 / U:2.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site