lkml.org 
[lkml]   [2019]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools lib traceevent: Fix memory leakage in filter_event
Em Thu, Dec 19, 2019 at 08:56:31PM -0500, Steven Rostedt escreveu:
> On Mon, 9 Dec 2019 01:35:49 -0500
> Hewenliang <hewenliang4@huawei.com> wrote:
>
> > It is necessary to call free_arg(arg) when add_filter_type returns NULL in
> > the function of filter_event.
> >
> > Signed-off-by: Hewenliang <hewenliang4@huawei.com>
>
> This looks fine.
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Arnaldo, care to take this?

Sure, just landed in acme/perf/urgent :)

- Arnaldo

> -- Steve
>
> > ---
> > tools/lib/traceevent/parse-filter.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> > index f3cbf86e51ac..20eed719542e 100644
> > --- a/tools/lib/traceevent/parse-filter.c
> > +++ b/tools/lib/traceevent/parse-filter.c
> > @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event,
> > }
> >
> > filter_type = add_filter_type(filter, event->id);
> > - if (filter_type == NULL)
> > + if (filter_type == NULL) {
> > + free_arg(arg);
> > return TEP_ERRNO__MEM_ALLOC_FAILED;
> > + }
> >
> > if (filter_type->filter)
> > free_arg(filter_type->filter);

\
 
 \ /
  Last update: 2019-12-20 22:49    [W:0.060 / U:3.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site