lkml.org 
[lkml]   [2019]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes
From
Date
19.12.2019 16:04, Richard Leitner пишет:
> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
> to alias it from derived boards.
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 9c58e7fcf5c0..e02f75757a7e 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -464,7 +464,7 @@
> clocks = <&tegra_car TEGRA20_CLK_RTC>;
> };
>
> - i2c@7000c000 {
> + i2c1: i2c@7000c000 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c000 0x100>;
> interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> @@ -494,7 +494,7 @@
> status = "disabled";
> };
>
> - i2c@7000c400 {
> + i2c2: i2c@7000c400 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c400 0x100>;
> interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> @@ -510,7 +510,7 @@
> status = "disabled";
> };
>
> - i2c@7000c500 {
> + i2c3: i2c@7000c500 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c500 0x100>;
> interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
>

Hello Richard,

Why derived boards couldn't label nodes by themselves? That's what all
derived boards are doing already.

BTW, upstream should benefit from the submitted changes. This is not a
very useful change for upstream if you're not updating the actual DTs of
any of the boards in arch/arm/boot/dts/*.

\
 
 \ /
  Last update: 2019-12-20 15:01    [W:0.137 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site