lkml.org 
[lkml]   [2019]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file
On Fri, Dec 20, 2019 at 09:37:19AM +0800, Jin Yao wrote:
> We observed an issue that was some extra columns displayed after switching
> perf data file in browser. The steps to reproduce:
>
> 1. perf record -a -e cycles,instructions -- sleep 3
> 2. perf report --group
> 3. In browser, we use hotkey 's' to switch to another perf.data
> 4. Now in browser, the extra columns 'Self' and 'Children' are displayed.
>
> The issue is setup_sorting() executed again after repeat path, so dimensions
> are added again.
>
> This patch checks the last key returned from __cmd_report(). If it's
> K_SWITCH_INPUT_DATA, skips the setup_sorting().
>
> v6:
> ---
> No change.
>
> v5:
> ---
> New patch in v5.
>
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>

for all 4 patches:

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

\
 
 \ /
  Last update: 2019-12-20 14:54    [W:0.085 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site