lkml.org 
[lkml]   [2019]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 11/19] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier
    Date
    There is no good justification for smp_rmb() after returning from LP2
    because there are no memory operations that require SMP synchronization.
    Thus remove the confusing barrier.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    arch/arm/mach-tegra/cpuidle-tegra20.c | 2 --
    arch/arm/mach-tegra/cpuidle-tegra30.c | 2 --
    2 files changed, 4 deletions(-)

    diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
    index 3f4c75dbb4aa..78cc424fac35 100644
    --- a/arch/arm/mach-tegra/cpuidle-tegra20.c
    +++ b/arch/arm/mach-tegra/cpuidle-tegra20.c
    @@ -193,8 +193,6 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev,

    local_fiq_enable();

    - smp_rmb();
    -
    return entered_lp2 ? index : 0;
    }
    #endif
    diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c
    index a4f0add46a27..80ae64bcdf50 100644
    --- a/arch/arm/mach-tegra/cpuidle-tegra30.c
    +++ b/arch/arm/mach-tegra/cpuidle-tegra30.c
    @@ -113,8 +113,6 @@ static int tegra30_idle_lp2(struct cpuidle_device *dev,

    local_fiq_enable();

    - smp_rmb();
    -
    return (entered_lp2) ? index : 0;
    }
    #endif
    --
    2.24.0
    \
     
     \ /
      Last update: 2019-12-03 01:43    [W:2.537 / U:1.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site