| Date | Mon, 2 Dec 2019 11:32:22 -0800 | From | Sean Christopherson <> | Subject | Re: [PATCH RFC 02/15] KVM: Add kvm/vcpu argument to mark_dirty_page_in_slot |
| |
On Fri, Nov 29, 2019 at 04:34:52PM -0500, Peter Xu wrote:
Why?
> From: "Cao, Lei" <Lei.Cao@stratus.com> > > Signed-off-by: Cao, Lei <Lei.Cao@stratus.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > virt/kvm/kvm_main.c | 26 +++++++++++++++++--------- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index fac0760c870e..8f8940cc4b84 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -145,7 +145,10 @@ static void hardware_disable_all(void); > > static void kvm_io_bus_destroy(struct kvm_io_bus *bus); > > -static void mark_page_dirty_in_slot(struct kvm_memory_slot *memslot, gfn_t gfn); > +static void mark_page_dirty_in_slot(struct kvm *kvm, > + struct kvm_vcpu *vcpu, > + struct kvm_memory_slot *memslot, > + gfn_t gfn);
Why both? Passing @vcpu gets you @kvm.
|