Messages in this thread |  | | Date | Thu, 19 Dec 2019 18:22:25 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2 2/3] dt-bindings: power: Add the bq2515x family dt bindings |
| |
Hi,
On Tue, Oct 29, 2019 at 03:02:00PM -0500, Dan Murphy wrote: > Add the bindings for the bq25150 and bq25155 500mA > charging ICs from Texas Instruments. > > Datasheet: > http://www.ti.com/lit/ds/symlink/bq25150.pdf > http://www.ti.com/lit/ds/symlink/bq25155.pdf > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > CC: Rob Herring <robh@kernel.org> > --- > > v2 - Converted to yaml format and removed ti,* properties for already defined > properties > > .../bindings/power/supply/bq2515x.yaml | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > new file mode 100644 > index 000000000000..4e6225056f45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) 2019 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: TI bq2515x 500-mA Linear charger family > + > +maintainers: > + - Dan Murphy <dmurphy@ti.com> > + > +description: | > + The BQ2515x family is a highly integrated battery charge management IC that > + integrates the most common functions for wearable devices, namely a charger, > + an output voltage rail, ADC for battery and system monitoring, and > + push-button controller. > + > + Specifications about the charger can be found at: > + http://www.ti.com/lit/ds/symlink/bq25150.pdf > + http://www.ti.com/lit/ds/symlink/bq25155.pdf > + > +properties: > + compatible: > + enum: > + - ti,bq25150 > + - ti,bq25155 > + > + reg: > + maxItems: 1 > + > + pg-gpios: > + description: | > + GPIO used for connecting the bq2515x device PG (Power Good) > + pin. This pin should be used if possible as this is the > + recommended way to obtain the charger's input PG state. > + If this pin is not specified a software-based approach for PG > + detection is used. > + > + reset-gpios: > + description: | > + GPIO used for hardware reset. > + > + low-power-gpios: > + description: | > + GPIO used for low power mode of IC. > + > + charge-enable-gpios: > + description: | > + GPIO used to turn on and off charging.
Above looks ok to me.
> + constant-charge-current-max-microamp: > + description: | > + Maximum charging current in micro Amps. > + minimum: 50000 > + maximum: 600000 > + > + voltage-max-design-microvolt: > + description: | > + Maximum charging voltage in micro volts. > + minimum: 3600000 > + maximum: 4600000
These two should use the simple-battery binding, as seen in Documentation/devicetree/bindings/power/supply/battery.txt
-- Sebastian
> + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + charger@6b { > + compatible = "ti,bq25150"; > + reg = <0x6b>; > + > + pg-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > + low-power-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>; > + charge-enable-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; > + constant-charge-current-max-microamp = <300000>; > + voltage-max-design-microvolt = <4200000>; > + }; > + }; > -- > 2.22.0.214.g8dca754b1e > [unhandled content-type:application/pgp-signature] |  |