[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 1/2] IMA: Define workqueue for early boot "key" measurements
On 12/19/19 5:11 AM, Mimi Zohar wrote:

> Getting rid of the temporary list is definitely a big improvement.  As
> James suggested, using test_and_set_bit() and test_bit() would improve
> this code even more.  I think, James correct me if I'm wrong, you
> would be able to get rid of both the mutex and "process".
> Mimi

I am not sure if the mutex can be removed.

In ima_queue_key() we need to test the flag and add the key to the list
as an atomic operation:

if (!test_bit())

Suppose the if condition is true, but before we could insert the key to
the list, ima_process_queued_keys() runs and processes queued keys we'll
add the key to the list and never process it.

Is there an API in the kernel to test and add an entry to a list


 \ /
  Last update: 2019-12-19 17:57    [W:0.086 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site