lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] dt-bindings: edac: Add DT bindings for Kryo EDAC
On Thu, Dec 19, 2019 at 12:50 AM Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Hi Rob,
>
> On 2019-12-19 05:07, Rob Herring wrote:
> > On Thu, Dec 05, 2019 at 09:53:05AM +0000, Sai Prakash Ranjan wrote:
> >> This adds DT bindings for Kryo EDAC implemented with RAS
> >> extensions on KRYO{3,4}XX CPU cores for reporting of cache
> >> errors.
> >>
> >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> >> ---
> >> .../bindings/edac/qcom-kryo-edac.yaml | 67
> >> +++++++++++++++++++
> >> 1 file changed, 67 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml
> >> b/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml
> >> new file mode 100644
> >> index 000000000000..1a39429a73b4
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml
> >> @@ -0,0 +1,67 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/edac/qcom-kryo-edac.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Kryo Error Detection and Correction(EDAC)
> >> +
> >> +maintainers:
> >> + - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> >> +
> >> +description: |
> >> + Kryo EDAC is defined to describe on-chip error detection and
> >> correction
> >> + for the Kryo CPU cores which implement RAS extensions. It will
> >> report
> >> + all Single Bit Errors and Double Bit Errors found in L1/L2 caches
> >> in
> >> + in two registers ERXSTATUS_EL1 and ERXMISC0_EL1. L3-SCU cache
> >> errors
> >> + are reported in ERR1STATUS and ERR1MISC0 registers.
> >> + ERXSTATUS_EL1 - Selected Error Record Primary Status Register,
> >> EL1
> >> + ERXMISC0_EL1 - Selected Error Record Miscellaneous Register 0,
> >> EL1
> >> + ERR1STATUS - Error Record Primary Status Register
> >> + ERR1MISC0 - Error Record Miscellaneous Register 0
> >> + Current implementation of Kryo ECC(Error Correcting Code) mechanism
> >> is
> >> + based on interrupts.
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - qcom,kryo-edac
> >> +
> >> + interrupts:
> >> + minItems: 1
> >> + maxItems: 4
> >> + items:
> >> + - description: l1-l2 cache faultirq interrupt
> >> + - description: l1-l2 cache errirq interrupt
> >> + - description: l3-scu cache errirq interrupt
> >> + - description: l3-scu cache faultirq interrupt
> >> +
> >> + interrupt-names:
> >> + minItems: 1
> >> + maxItems: 4
> >
> > You are saying only these combinations are valid:
> >
> > l1-l2-faultirq
> >
> > l1-l2-faultirq
> > l1-l2-errirq
> >
> > l1-l2-faultirq
> > l1-l2-errirq
> > l3-scu-errirq
> >
> > l1-l2-faultirq
> > l1-l2-errirq
> > l3-scu-errirq
> > l3-scu-faultirq
> >
> > Is that your intent?
> >
>
> No, I want any combination of interrupts to be valid with atleast one
> interrupt as mandatory.
> I thought specifying minItems as 1 and maxItems as 4 will take care of
> this, am I doing something wrong?

Interrupts (really all properties) have a defined order in DT and an
'items' list defines both the order and index. You'll need to use
oneOf and list out the possibilities. Stick to ones you actually need.

Rob

\
 
 \ /
  Last update: 2019-12-19 14:58    [W:0.049 / U:3.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site