lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/13] dt-bindings: PCI: Add host mode dt-bindings for TI's J721E SoC
From
Date
Hi,

On 19/12/19 5:38 am, Rob Herring wrote:
> On Mon, Dec 09, 2019 at 02:51:43PM +0530, Kishon Vijay Abraham I wrote:
>> Add host mode dt-bindings for TI's J721E SoC.
>>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> .../bindings/pci/ti,j721e-pci-host.yaml | 161 ++++++++++++++++++
>> 1 file changed, 161 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> new file mode 100644
>> index 000000000000..96184e1f419f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> @@ -0,0 +1,161 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/pci/ti,j721e-pci-host.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: TI J721E PCI Host (PCIe Wrapper)
>> +
>> +maintainers:
>> + - Kishon Vijay Abraham I <kishon@ti.com>
>
> There's now a PCI bus schema. Reference it here:
>
> allOf:
> - $ref: "/schemas/pci/pci-bus.yaml#"
>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ti,j721e-pcie-host
>
> Indentation.
>
>> +
>> + reg:
>> + maxItems: 4
>> +
>> + reg-names:
>> + items:
>> + - const: intd_cfg
>> + - const: user_cfg
>> + - const: reg
>> + - const: cfg
>> +
>> + ti,syscon-pcie-ctrl:
>> + description: Phandle to the SYSCON entry required for configuring PCIe mode
>> + and link speed.
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle
>
> You can drop the 'allOf' here if there aren't more constraints.
>
>> +
>> + max-link-speed:
>> + minimum: 1
>> + maximum: 3
>> +
>> + num-lanes:
>> + minimum: 1
>> + maximum: 2
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> + description: clock-specifier to represent input to the PCIe
>> +
>> + clock-names:
>> + items:
>> + - const: fck
>> +
>
>> + "#address-cells":
>> + const: 3
>> +
>> + "#size-cells":
>> + const: 2
>> +
>> + bus-range:
>> + description: Range of bus numbers associated with this controller.
>
> Drop these 3 as they are all standard.
>
>> +
>> + cdns,max-outbound-regions:
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/int32
>
> Can be negative? Use uint32.
>
> The int* definitions are kind of broken until dtc is fixed to maintain
> sign.
>
>> + - enum: [16]
>
> const: 16
>
>> +
>> + cdns,no-bar-match-nbits:
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/int32
>> + - enum: [64]
>> +
>> + vendor-id:
>> + const: 0x104c
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>
> And elsewhere. Drop the description.
>
>> +
>> + device-id:
>> + const: 0xb00d
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>> +
>> + msi-map: true
>> +
>> + dma-coherent:
>> + description: Indicates that the PCIe IP block can ensure the coherency
>> +
>> + ranges: true
>
> Don't you know how many?
>
>> +
>> + reset-gpios:
>> + description: GPIO specifier for the PERST# signal
>> +
>> + phys:
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>> +
>> + phy-names:
>> + description: As defined in
>> + Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - ti,syscon-pcie-ctrl
>> + - max-link-speed
>> + - num-lanes
>> + - power-domains
>> + - clocks
>> + - clock-names
>
>> + - "#address-cells"
>> + - "#size-cells"
>
> Can drop these 2. The bus schema requires them.
>
>> + - bus-range
>> + - cdns,max-outbound-regions
>> + - cdns,no-bar-match-nbits
>> + - vendor-id
>> + - device-id
>> + - msi-map
>> + - dma-coherent
>> + - ranges
>
> Can drop, too.
>
>> + - reset-gpios
>
> Isn't having this board dependent?

All board dts files should have it though.
I'll fix all the comments given here.

Thanks
Kishon

\
 
 \ /
  Last update: 2019-12-19 14:12    [W:0.156 / U:6.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site