lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"
From
Date
Hello,

Because I used gmail mobile app to response and the app decided that
always using HTML is a valid choice for every one, my previous mail
rejected by mailing lists.

Because of that I am (re)sending this mail. You can find contents of my
previous mail below.

Regards,
Mehmet Akif.

> Hi Roman,
>
> Unfortunately I don't have XPS 13 and tested the patch on Dell Vostro
> 5481 and this patch is the result of bisection on Vostro.
>
> At first, the Archlinux bug report I shared looked similar thus that
> bug report contains lots of dmesg outputs from different users. But
> yes probably there is 2 distinct issue which should be solved separately.
>
> I will update commit message accordingly as soon as possible.
>
> Regards,
> Mehmet Akif
>
>
> On Wed, Dec 18, 2019, 22:12 Roman Gilg <subdiff@gmail.com
> <mailto:subdiff@gmail.com>> wrote:
>
> On Fri, Dec 13, 2019 at 9:36 PM Mehmet Akif Tasova
> <makiftasova@gmail.com <mailto:makiftasova@gmail.com>> wrote:
> >
> > Since Linux 5.4.1 released, iwlwifi could not initialize
> Intel(R) Dual Band
> > Wireless AC 9462 firmware, failing with following error in dmesg:
> >
> > iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD
> >
> > whole dmesg output of error can be found at:
> > https://gist.github.com/makiftasova/354e46439338f4ab3fba0b77ad5c19ec
> >
> > also bug report from ArchLinux bug tracker (contains more info):
> > https://bugs.archlinux.org/task/64703
>
> Since this bug report is about the Dell XPS 13 2-in1: I tested your
> revert with this device, but the issue persists at least on this
> device. So these might be two different issues, one for your device
> and another one for the XPS.
>
> > Reverting commit 06eb547c4ae4 ("iwlwifi: mvm: fix scan config
> command
> > size") seems to fix this issue  until proper solution is found.
> >
> > This reverts commit 06eb547c4ae4382e70d556ba213d13c95ca1801b.
> >
> > Signed-off-by: Mehmet Akif Tasova <makiftasova@gmail.com
> <mailto:makiftasova@gmail.com>>
> > ---
> >  drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> > index a046ac9fa852..a5af8f4128b1 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> > @@ -1213,7 +1213,7 @@ static int
> iwl_mvm_legacy_config_scan(struct iwl_mvm *mvm)
> >                 cmd_size = sizeof(struct iwl_scan_config_v2);
> >         else
> >                 cmd_size = sizeof(struct iwl_scan_config_v1);
> > -       cmd_size += num_channels;
> > +       cmd_size += mvm->fw->ucode_capa.n_scan_channels;
> >
> >         cfg = kzalloc(cmd_size, GFP_KERNEL);
> >         if (!cfg)
> > --
> > 2.24.1
> >
>

\
 
 \ /
  Last update: 2019-12-19 11:16    [W:0.093 / U:2.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site