lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nfsd: remove unnecessary assertion in nfsd4_encode_replay
Thanks, applying.--b.

On Tue, Dec 17, 2019 at 04:50:47PM -0600, Aditya Pakki wrote:
> The replay variable is set in the only caller of nfsd4_encode_replay.
> The assertion is unnecessary and the patch removes this check.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> fs/nfsd/nfs4xdr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index d2dc4c0e22e8..fb2433676376 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4500,8 +4500,6 @@ nfsd4_encode_replay(struct xdr_stream *xdr, struct nfsd4_op *op)
> __be32 *p;
> struct nfs4_replay *rp = op->replay;
>
> - BUG_ON(!rp);
> -
> p = xdr_reserve_space(xdr, 8 + rp->rp_buflen);
> if (!p) {
> WARN_ON_ONCE(1);
> --
> 2.20.1

\
 
 \ /
  Last update: 2019-12-19 23:47    [W:0.071 / U:1.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site