lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v5] lib/dynamic_debug: make better dynamic log output
From
Date


On 12/19/19 2:47 AM, Huang Shijie wrote:
> The driver strings, device name and net device name are not changed for
> the driver's dynamic log output. But the dynamic_emit_prefix() which contains
> the function names may change when the function names are changed.
>
> So the patch makes the better dynamic log output.

Another point here is that currently the output precisely matches the
non-dynamic debug counterpart strings if not prefix is emitted. So that
changes with this patch. I think its nice to say that the output is the
same as the non dynamic debug output except it may have an optional
prefix....


>
> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> ---
> v4 --> v5:
> remove the redundant whitespce in the tail.
> ---
> lib/dynamic_debug.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index c60409138e13..bfc3b386d603 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -589,9 +589,9 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor,
> } else {
> char buf[PREFIX_SIZE];
>
> - dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV",
> - dynamic_emit_prefix(descriptor, buf),
> + dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s %s %s%pV",
> dev_driver_string(dev), dev_name(dev),
> + dynamic_emit_prefix(descriptor, buf),
> &vaf);
> }
>
> @@ -619,11 +619,11 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor,
> char buf[PREFIX_SIZE];
>
> dev_printk_emit(LOGLEVEL_DEBUG, dev->dev.parent,
> - "%s%s %s %s%s: %pV",
> - dynamic_emit_prefix(descriptor, buf),
> + "%s %s %s %s %s%pV",
> dev_driver_string(dev->dev.parent),
> dev_name(dev->dev.parent),
> netdev_name(dev), netdev_reg_state(dev),
> + dynamic_emit_prefix(descriptor, buf),
> &vaf);
> } else if (dev) {
> printk(KERN_DEBUG "%s%s: %pV", netdev_name(dev),
> @@ -655,11 +655,11 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
> char buf[PREFIX_SIZE];
>
> dev_printk_emit(LOGLEVEL_DEBUG, ibdev->dev.parent,
> - "%s%s %s %s: %pV",
> - dynamic_emit_prefix(descriptor, buf),
> + "%s %s %s %s%pV",
> dev_driver_string(ibdev->dev.parent),
> dev_name(ibdev->dev.parent),
> dev_name(&ibdev->dev),
> + dynamic_emit_prefix(descriptor, buf),
> &vaf);
> } else if (ibdev) {
> printk(KERN_DEBUG "%s: %pV", dev_name(&ibdev->dev), &vaf);
>

\
 
 \ /
  Last update: 2019-12-19 23:12    [W:0.196 / U:5.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site