lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v1 08/15] dt-bindings: phy: phy-cadence-torrent: Add clock bindings
On Wed, Dec 11, 2019 at 02:09:13PM +0100, Yuti Amonkar wrote:
> Add Torrent PHY reference clock bindings.
>
> Signed-off-by: Yuti Amonkar <yamonkar@cadence.com>
> ---
> .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index 4fa9d0a..8069498 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -17,6 +17,14 @@ properties:
> compatible:
> const: cdns,torrent-phy
>
> + clocks:
> + maxItems: 1
> + description:
> + PHY reference clock. Must contain an entry in clock-names.
> +
> + clock-names:
> + const: "refclk"

Don't need quotes. You don't really need *-names when there's only one
entry.

> +
> reg:
> items:
> - description: Offset of the DPTX PHY configuration registers.
> @@ -41,6 +49,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names

ABI again. You can't add new required properties.

> - reg
> - "#phy-cells"
>
> @@ -53,5 +63,7 @@ examples:
> num_lanes = <4>;
> max_bit_rate = <8100>;
> #phy-cells = <0>;
> + clocks = <&ref_clk>;
> + clock-names = "refclk";
> };
> ...
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-12-19 22:15    [W:0.145 / U:8.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site