lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 101/162] rtlwifi: rtl8192de: Fix missing code to retrieve RX buffer address
    Date
    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit 0e531cc575c4e9e3dd52ad287b49d3c2dc74c810 upstream.

    In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for
    new drivers"), a callback to get the RX buffer address was added to
    the PCI driver. Unfortunately, driver rtl8192de was not modified
    appropriately and the code runs into a WARN_ONCE() call. The use
    of an incorrect array is also fixed.

    Fixes: 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers")
    Cc: Stable <stable@vger.kernel.org> # 3.18+
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
    @@ -843,13 +843,15 @@ u32 rtl92de_get_desc(u8 *p_desc, bool is
    break;
    }
    } else {
    - struct rx_desc_92c *pdesc = (struct rx_desc_92c *)p_desc;
    switch (desc_name) {
    case HW_DESC_OWN:
    - ret = GET_RX_DESC_OWN(pdesc);
    + ret = GET_RX_DESC_OWN(p_desc);
    break;
    case HW_DESC_RXPKT_LEN:
    - ret = GET_RX_DESC_PKT_LEN(pdesc);
    + ret = GET_RX_DESC_PKT_LEN(p_desc);
    + break;
    + case HW_DESC_RXBUFF_ADDR:
    + ret = GET_RX_DESC_BUFF_ADDR(p_desc);
    break;
    default:
    RT_ASSERT(false, "ERR rxdesc :%d not process\n",

    \
     
     \ /
      Last update: 2019-12-19 20:11    [W:3.923 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site