lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -next] pci: fix a -Wtype-limits compilation warning
Date


> On Dec 18, 2019, at 1:24 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> Ugh, that is pretty subtle! Would you mind if we used "unsigned int"
> instead of "u16"? "u16" makes it look like just a mistake -- somebody
> is likely to come along and say devfn only needs "u8" and try to
> change it back. The same might happen with "unsigned int", but at
> least it doesn't look like it was chosen specifically to fit a devfn.
>
> Provisional patch below.

Looks good to me.

\
 
 \ /
  Last update: 2019-12-18 21:09    [W:0.042 / U:2.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site