Messages in this thread |  | | From | Doug Anderson <> | Date | Wed, 18 Dec 2019 10:37:53 -0800 | Subject | Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings |
| |
Hi,
On Wed, Dec 18, 2019 at 4:41 AM Sandeep Maheswaram (Temp) <sanm@codeaurora.org> wrote: > + assigned-clock-rates: > + description: > + Should be 19.2MHz (19200000) for MOCK_UTMI_CLK > + >=125MHz (125000000) for MASTER_CLK in SS mode > + >=60MHz (60000000) for MASTER_CLK in HS mode > + maxItems: 2 > > You can still express some limits here even if we don't go all out > with the "oneOf". AKA I think this is better: > > assigned-clock-rates: > items: > - const: 19200000 > - minimum: 60000000 > description: >= 60 MHz in HS mode, >= 125 MHz in SS mode > > Facing error when i add as above. > properties:assigned-clock-rates: {'items': [{'const': 19200000}, {'minimum': 60000000}]} is not valid under any of the given schemas > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/qcom,dwc3.example.dts' failed
I couldn't figure it out either. ...but at least this seemed to work and is slightly better than what you have:
assigned-clock-rates: items: - description: Must be 19.2MHz (19200000) - description: Must be >= 60 MHz in HS mode, >= 125 MHz in SS mode
So I'd say go with that.
-Doug
|  |