lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/4] x86: fix get_nr_restart_syscall()
Andy, Linus, do you have any objections?

On 12/03, Oleg Nesterov wrote:
>
> This version follows the latest recommendation from Linus,
> arch_set_restart_data() just saves ti->status in restart->arch_data.
>
> Andy, I can add another patch or change 4/4 to save the syscall number
> instead, I am fine either way.
>
> However, personally I dislike restart->arch_data, imo 3/4 is all we need.
>
> I agree, set_restart_fn() is better than the ugly ERESTART_RESTARTBLOCK
> check in syscall_return_slowpath() added by v1. But to me the x86-only
> arch_data field in restart_block is much worse than the sticky TS_ flag.
>
> To remind, there is another reason for the "transient" 3/4, 4/4 is not
> easily backportable.
>
> Oleg.
> ---
> arch/x86/include/asm/processor.h | 9 ---------
> arch/x86/include/asm/thread_info.h | 15 ++++++++++++++-
> arch/x86/kernel/signal.c | 24 +-----------------------
> fs/select.c | 10 ++++------
> include/linux/restart_block.h | 1 +
> include/linux/thread_info.h | 12 ++++++++++++
> kernel/futex.c | 3 +--
> kernel/time/alarmtimer.c | 2 +-
> kernel/time/hrtimer.c | 2 +-
> kernel/time/posix-cpu-timers.c | 2 +-
> 10 files changed, 36 insertions(+), 44 deletions(-)

\
 
 \ /
  Last update: 2019-12-18 16:20    [W:0.087 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site